testing: port remaining cloud tests to integration testing framework (SC-191) #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
approved these changes
Aug 6, 2021
| @@ -0,0 +1,175 @@ | |||
| # This file is part of cloud-init. See LICENSE file for license information. | |||
| """A set of somewhat unrelated tests that can be combined into a single | |||
There was a problem hiding this comment.
+1 on consolidation here of completely unrelated tests. If we find that the interaction of such tests cost us much in terms of lost signal or unexpected cross-module interaction we can separate them in the future. Our integration tests are expensive to setup and to run as far as time. so it's good to be as broad as possible with our tests.
TheRealFalcon
added a commit
to TheRealFalcon/cloud-init
that referenced
this pull request
Aug 10, 2021
…(SC-191) (canonical#955) This should enable us to remove the cloud-tests entirely.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Actually removing cloud tests can come separately.
Test Steps
pytest tests/integration_tests
Checklist: