-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distros/photon.py: refactor hostname handling #958
Conversation
Hi @TheRealFalcon - can you please review this change? You suggested to use this in my very first PR, at that time I took a part of hostname related chnages from RHEL distro code. Now I have tried to make it better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I added two small minor suggestions inline, but they won't block merge.
LOG.debug('Attempting to run: %s', cmd) | ||
try: | ||
(out, err) = subp.subp(cmd, capture=capture) | ||
if err: | ||
LOG.warning('Running %s resulted in stderr output: %s', | ||
cmd, err) | ||
return True, out, err | ||
return True, out, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the return values here.
If a command fails, this will return True else False.
@TheRealFalcon - I have added networkd activator in this PR now. Please take a look. |
Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Welcome and thank you too. |
Signed-off-by: Shreenidhi Shedi sshedi@vmware.com