distros/photon.py: refactor hostname handling #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TheRealFalcon - can you please review this change? You suggested to use this in my very first PR, at that time I took a part of hostname related chnages from RHEL distro code. Now I have tried to make it better. |
TheRealFalcon
approved these changes
Aug 5, 2021
sshedi
commented
Aug 6, 2021
| LOG.debug('Attempting to run: %s', cmd) | ||
| try: | ||
| (out, err) = subp.subp(cmd, capture=capture) | ||
| if err: | ||
| LOG.warning('Running %s resulted in stderr output: %s', | ||
| cmd, err) | ||
| return True, out, err | ||
| return True, out, err |
There was a problem hiding this comment.
Changed the return values here.
If a command fails, this will return True else False.
|
@TheRealFalcon - I have added networkd activator in this PR now. Please take a look. |
Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
|
Welcome and thank you too. |
TheRealFalcon
pushed a commit
to TheRealFalcon/cloud-init
that referenced
this pull request
Aug 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreenidhi Shedi sshedi@vmware.com