Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if nic is up after sleep when trying to bring it up #972

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

aswinrajamannar
Copy link
Contributor

Proposed Commit Message

Azure: Check if interface is up after sleep when trying to bring it up

summary:

When bringing interface up by unbinding and then binding hv_netvsc driver, it might take a short delay after binding for the link to be up. So before trying unbind/bind again after sleep, check if the link is up. This is a corner case when a preprovisioned VM is reused and the NICs are hot-attached.

Test Steps

  • Deploy savable Pre-provisioned VMs whose NICs get hot-attached when they get reprovisioned
  • Reuse them for a multi-NIC VM. In some cases, this may show up as a delay for the VM to report ready because we aggressively unbind, bind and check of status immediately after the bind.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@aswinrajamannar aswinrajamannar marked this pull request as draft August 12, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants