Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unnecesary lcase in ds-identify #978

Merged

Conversation

akutz
Copy link
Contributor

@akutz akutz commented Aug 13, 2021

Proposed Commit Message

Revert unnecesary lcase in ds-identify

This patch reverts an unnecessary lcase optimization in the
ds-identify script. SystemD documents the values produced by
the systemd-detect-virt command are lower case, and the mapping
table used by the FreeBSD check is also lower-case.

The optimization added two new forked processes, needlessly
causing overhead.

Additional Context

Please see #970 (comment) for more information.

cc @smoser

Test Steps

$ make clean_pyc && PYTHONPATH="$(pwd)" python3 -m pytest -v tests/unittests/test_ds_identify.py

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

This patch reverts an unnecessary lcase optimization in the
ds-identify script. SystemD documents the values produced by
the systemd-detect-virt command are lower case, and the mapping
table used by the FreeBSD check is also lower-case.

The optimization added two new forked processes, needlessly
causing overhead.
@akutz akutz mentioned this pull request Aug 13, 2021
3 tasks
@TheRealFalcon TheRealFalcon merged commit f516a7d into canonical:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants