Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

growpart: adding LANG=C before the command sfdisk --version #30

Merged
merged 1 commit into from May 13, 2021

Conversation

xiachen-rh
Copy link
Contributor

@xiachen-rh xiachen-rh commented May 12, 2021

Fix issue LP: #1928167 growpart doesn't work when LANG=cs_CZ.UTF-8

@xiachen-rh xiachen-rh changed the title Adding LANG=C before the command sfdisk --version growpart: adding LANG=C before the command sfdisk --version May 12, 2021
Copy link
Collaborator

@paride paride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this LGTM, could you please just amend the commit message referring to the Launchpad as `LP: #1928167" instead of using the full launchpad URL? This will help tracking fixed bugs when generating changelogs. Thanks!

@xiachen-rh
Copy link
Contributor Author

Hi, this LGTM, could you please just amend the commit message referring to the Launchpad as `LP: #1928167" instead of using the full launchpad URL? This will help tracking fixed bugs when generating changelogs. Thanks!

Hi Paride,
thanks for your review. I changed the commit message, is it OK now? I don't have much experience of upstream contribution, so let me know if any problem, and I will follow the rule.
thanks,
Amy

@paride
Copy link
Collaborator

paride commented May 12, 2021

Hey @xiachen-rh, you changed the GitHub PR title, but not the actual commit message. For that you'll have to do something like:

$ git commit --amend # (from the tip of your branch)
$ git push --force # to update the branch on github

@xiachen-rh
Copy link
Contributor Author

Hey @xiachen-rh, you changed the GitHub PR title, but not the actual commit message. For that you'll have to do something like:

$ git commit --amend # (from the tip of your branch)
$ git push --force # to update the branch on github

Hi Paride,
My first commit was submitted via web UI on my master branch, but I didn't find the "amend" button, so I run the git command as you told me, it created a new commit bc3cfec, is it OK?

thanks,
Amy

Copy link
Collaborator

@paride paride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@paride paride merged commit 03aa997 into canonical:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants