Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

architecture parsing fails on non-linux platforms #474

Closed
mr-cal opened this issue Jun 15, 2023 · 1 comment
Closed

architecture parsing fails on non-linux platforms #474

mr-cal opened this issue Jun 15, 2023 · 1 comment

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Jun 15, 2023

Overview

Craft-parts fails to resolve system architectures on non-linux platforms.

Details

On a Linux arm64 machine,

craft-parts/craft_parts/infos.py

Line 431 in 8525c04

return platform.machine()

returns aarch64.

On Apple silicon, the same call returns arm64, and the subsequent dictionary lookup for _ARCH_TRANSLATIONS fails.

There was an old TODO for Windows architectures not working either, but I haven't verified this.

Craft-parts should be able to determine the architecture for Linux, Mac, and Windows.

Source
mr-cal added a commit that referenced this issue Jun 15, 2023
@mr-cal
info: convert TODO to bug
bee0111 
#474

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal mentioned this issue Jun 15, 2023
Merged
1 task
mr-cal added a commit that referenced this issue Jun 20, 2023
@mr-cal
info: convert TODO to bug (#475)
b94643c 
#474

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Collaborator Author

mr-cal commented Jun 26, 2023

Resolved by #476

@mr-cal mr-cal closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mr-cal