fix(sequencer): rerun steps only if explicitly requested #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmatsuoka
force-pushed
the
work/only-explicit-reruns
branch
from
4830243
to
1d08591
Compare
mr-cal
requested changes
May 16, 2024
mr-cal
approved these changes
May 24, 2024
cmatsuoka
force-pushed
the
work/only-explicit-reruns
branch
from
741532e
to
9d421db
Compare
Instead of implicitly cleaning and re-executing steps when a part name is specified, only do it when explicitly requested by the user. Applications must set the `rerun` argument accordingly when planning the lifecycle execution. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
work/only-explicit-reruns
branch
from
66db1ea
to
31f29a4
Compare
|
Rebased on feature/2.0 |
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
lengau
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of implicitly cleaning and re-executing steps when a part name
is specified, only do it when explicitly requested by the user.
Applications must set the
rerunargument accordingly when planningthe lifecycle execution.
Fixes canonical/snapcraft#4806