Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file based backend as a fallback #119

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Nov 21, 2023

Useful when a keyring is not available, such as when running on a headless system.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Fixes #109 #58

@sergiusens sergiusens force-pushed the CRAFT-2181-File-based-backend branch 5 times, most recently from 58ff35c to fdfb06b Compare November 21, 2023 21:17
All unit test should use the mocked keyring.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the CRAFT-2181-File-based-backend branch 2 times, most recently from a261b46 to e66dd0d Compare November 21, 2023 21:52
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

craft_store/auth.py Show resolved Hide resolved
Useful when a keyring is not available, such as when running on a headless
system.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens merged commit 40e1141 into main Nov 22, 2023
14 checks passed
@sergiusens sergiusens deleted the CRAFT-2181-File-based-backend branch November 22, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File based backend
3 participants