breaking(build_charms_with_cache.yaml): Add workaround for charmcraft 2.5 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2.5 charmcraft 2.5's new caching implementation breaks this workflow. We plan to migrate to the new caching system, but are blocked by this bug: canonical/charmcraft#1374. In the meantime, we can hack charmcraft 2.5's new caching system into the old caching system Migration required from breaking change: - old caches need to be deleted - tox `build` environments (that wrap `charmcraft pack`) need to add `CRAFT_SHARED_CACHE` to pass_env
carlcsaposs-canonical
requested review from
taurus-forever and
shayancanonical
|
tested on canonical/mysql-router-k8s-operator#171 |
dmitry-ratushnyy
approved these changes
Dec 1, 2023
paulomach
approved these changes
Dec 1, 2023
delgod
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charmcraft 2.5's new caching implementation breaks this workflow. We plan to migrate to the new caching system, but are blocked by this bug: canonical/charmcraft#1374. In the meantime, we can hack charmcraft 2.5's new caching system into the old caching system
Migration required for breaking change:
buildenvironments (that wrapcharmcraft pack) need to addCRAFT_SHARED_CACHEto pass_env