fix: use new sdi 0.3.6 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#136 Summary of changes: - Pinned SDDI to 0.3.6 that has a fix. Details are in canonical/bundle-kubeflow#648
Summary of changes: - Pinned juju channel.
This was referenced Jul 26, 2023
Closed
DnPlas
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Thanks @i-chvets ! I think that to keep changes at a minimum, I'd suggest you only re-generate the dependencies of the packages that are updated by this PR. If we are only focusing on SDI 0.3.5, let's try to manually run pip-compile against just that package and see how it goes.
Ideally we want to preserve the state of this branch as much as possible.
added 9 commits
July 27, 2023 08:53
…r into fix-sdi-0.3.6
…r into fix-sdi-0.3.6
…r into fix-sdi-0.3.6
|
@DnPlas Please review. The least amount of changes to make this work in track/2.31 |
DnPlas
reviewed
Jul 27, 2023
DnPlas
reviewed
Jul 27, 2023
DnPlas
reviewed
Jul 27, 2023
DnPlas
reviewed
Jul 28, 2023
DnPlas
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for broken requirements in dex on track/2.31
Details are in: #136
Summary of changes: