feat: make charm work on airgap environments #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Dex Charm is doing apt install. Update this logic to ensure the Dex Charm can work in an airgapped environment. Closes #100 Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
Some of this charm dependencies need rustc and cargo to build and install from source, poviding this toolchain and library ensures the right tools are installed in the environment, preventing issues when pip installing charm dependencies. Partial cherry-pick of a716963
i-chvets
approved these changes
Sep 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks 4e42ce3, partially cherry-picks a716963, and makes changes to the requirements.* files so that dex-auth can be deployed in an airgap environment. These changes are mirroring in
track/2.31what we currently have inmain.Fixes #167