Improve instructions for installing dotrun #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
force-pushed
the
pip-instructions
branch
from
f166294
to
bbbf9ba
Compare
edlerd
reviewed
Nov 22, 2022
| @@ -29,8 +29,25 @@ $ dotrun --env FOO=bar {script} # Run {script} with FOO environment variable | |||
|
|
|||
| ## Installation | |||
|
|
|||
| ### Linux | |||
There was a problem hiding this comment.
Can we add a note here, that you want to add the local user to the docker group? Otherwise dotrun needs to be run as root or at least a user who is in the docker group.
There was a problem hiding this comment.
I've added a section about setting up Docker. Does that look about right?
edlerd
approved these changes
Nov 23, 2022
| @@ -29,8 +29,25 @@ $ dotrun --env FOO=bar {script} # Run {script} with FOO environment variable | |||
|
|
|||
| ## Installation | |||
|
|
|||
| ### Linux | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some more detailed instructions for installing pip/python.