Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to flask #45

Merged
merged 4 commits into from
Apr 28, 2020
Merged

Conversation

solazio
Copy link
Contributor

@solazio solazio commented Apr 23, 2020

Done

  • Convert site to flask
  • Implement vanilla side-nav for /docs
  • Add GitHub PR template
  • Add webpack and husky

Issue

Fix #44

QA

I get this error locally and I don't know how to fix it. The styles are applied even though I get the error. Perhaps you can help.
image

@webteam-app
Copy link

@solazio solazio force-pushed the 44-convert-site-to-flask branch 2 times, most recently from 39d498d to a2cffda Compare April 23, 2020 15:59
@anthonydillon
Copy link
Contributor

I get this error testing:

./run test
 
Yarn dependencies haven't changed. To force an update, delete .yarn.canonical-webteam-dqlite.io-7decceb9.hash.
Pip dependencies haven't changed. To force an update, delete .pip.canonical-webteam-dqlite.io-7decceb9.hash.
- Running yarn tests
 
yarn run v1.15.2
warning package.json: License should be a valid SPDX license expression
$ yarn run lint-scss && yarn run lint-python && yarn run test-python
warning package.json: License should be a valid SPDX license expression
$ stylelint static/**/*.scss
warning package.json: License should be a valid SPDX license expression
$ flake8 webapp tests && black --check --line-length 79 webapp tests
/bin/sh: 1: black: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
===
Tests failed
===

.env Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
run Show resolved Hide resolved
static/js/base.js Outdated Show resolved Hide resolved
webapp/app.py Outdated Show resolved Hide resolved
@solazio solazio force-pushed the 44-convert-site-to-flask branch 2 times, most recently from a2fe7cc to 5c5f6a8 Compare April 24, 2020 13:10
Copy link
Contributor

@tbille tbille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I am fine with it. But is the navigation in the docs correct?
It doesn't looks like the others that we have.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
@solazio solazio force-pushed the 44-convert-site-to-flask branch 2 times, most recently from d861a1b to 4ee1c83 Compare April 28, 2020 09:17
@anthonydillon
Copy link
Contributor

Docs look good to me 👍 thanks @solazio

Copy link
Contributor

@tbille tbille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉
Awesome thanks for that!

@tbille tbille merged commit 8eda3d3 into canonical:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert site from Jekyll to Flask
6 participants