Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: Don't unnecessarily realloc in loop. #390

Merged
merged 1 commit into from Sep 2, 2022
Merged

buffer: Don't unnecessarily realloc in loop. #390

merged 1 commit into from Sep 2, 2022

Conversation

MathieuBordere
Copy link
Contributor

Small optimization in order not to realloc the data buffer multiple times in the loop.

cole-miller
cole-miller approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@cole-miller cole-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- nice catch.

@stgraber stgraber merged commit 3a6fa2e into canonical:master Sep 2, 2022
@MathieuBordere MathieuBordere deleted the buffer-realloc branch December 9, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-miller cole-miller cole-miller approved these changes

@freeekanayaka freeekanayaka Awaiting requested review from freeekanayaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MathieuBordere @cole-miller @stgraber