fsm: Don't ignore return value in fsm__apply. #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 73.68% 73.83% +0.14%
==========================================
Files 31 31
Lines 4682 4685 +3
Branches 1462 1467 +5
==========================================
+ Hits 3450 3459 +9
+ Misses 742 735 -7
- Partials 490 491 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MathieuBordere
force-pushed
the
fsm_apply_rc
branch
from
63d4ebd
to
71979c5
Compare
|
I'll still try to add a test for this one, but it's a pretty obvious bug. |
MathieuBordere
force-pushed
the
fsm_apply_rc
branch
from
71979c5
to
57e524a
Compare
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
MathieuBordere
force-pushed
the
fsm_apply_rc
branch
from
57e524a
to
67915a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ignoring all
apply_xxxreturn values except in theswitchdefault:branch.Signed-off-by: Mathieu Borderé mathieu.bordere@canonical.com