Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert tolerance for EAGAIN when probing async I/O #641

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Revert tolerance for EAGAIN when probing async I/O #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/raft/uv_fs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,14 +840,6 @@ static int probeAsyncIO(int fd, size_t size, bool *ok, char *errmsg)
* errors, since we allocated the file with posix_fallocate and
* the block size is supposed to be correct. */
*ok = false;
if (event.res == -EAGAIN) {
/* If EAGAIN is encountered we assume the functionality
* is supported but this write would have blocked for
* some reason. UvWriter has a fallback mechanism to
* schedule writes on the thread pool in case the async
* write fails with EAGAIN, so this is safe. */
*ok = true;
}
}

return 0;
Expand Down
Loading