-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Test with musl #682
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 77.87% 78.66% +0.79%
==========================================
Files 197 197
Lines 27953 27964 +11
Branches 5534 5541 +7
==========================================
+ Hits 21768 21998 +230
+ Misses 4346 4059 -287
- Partials 1839 1907 +68 ☔ View full report in Codecov by Sentry. |
Running into this issue it seems: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764335. |
b445c6d
to
78dddc5
Compare
contrib/build-static.sh
Outdated
REPO_SQLITE="https://github.com/sqlite/sqlite" | ||
REPO_DQLITE="https://github.com/cole-miller/dqlite" | ||
|
||
TAG_MUSL_COMPAT="main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please include a test run against the musl tag used in our k8s distributions: https://github.com/canonical/k8s-dqlite/blob/master/hack/env.sh#L13? We might not always be on the same musl version as the juju team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juju will be happy to move to the later one, now we know the root cause. We intended to move that originally but ended up locating the segfault.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
92c73e8
to
5f862d2
Compare
I like how using a Dockerfile for this cleans things up. Looking into the segfaults. |
4d602a1
to
d500916
Compare
musl doesn't have this header and it seems we don't use it. Signed-off-by: Cole Miller <cole.miller@canonical.com>
This clashes with a #define in a system header. Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
MicroK8s and Juju consume dqlite as a static library build against musl libc, so let's test this in our CI to avoid unexpected breaks like #679.
Signed-off-by: Cole Miller cole.miller@canonical.com