Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Test with musl #682

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

Conversation

cole-miller
Copy link
Contributor

MicroK8s and Juju consume dqlite as a static library build against musl libc, so let's test this in our CI to avoid unexpected breaks like #679.

Signed-off-by: Cole Miller cole.miller@canonical.com

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 39.39394% with 20 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (2d0d71b) to head (4a512aa).
Report is 1 commits behind head on master.

Files Patch % Lines
test/raft/integration/test_uv_tcp_listen.c 0.00% 6 Missing and 6 partials ⚠️
test/raft/integration/test_uv_tcp_connect.c 16.66% 3 Missing and 2 partials ⚠️
src/raft/uv.c 60.00% 2 Missing ⚠️
test/lib/heap.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   77.87%   78.66%   +0.79%     
==========================================
  Files         197      197              
  Lines       27953    27964      +11     
  Branches     5534     5541       +7     
==========================================
+ Hits        21768    21998     +230     
+ Misses       4346     4059     -287     
- Partials     1839     1907      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cole-miller
Copy link
Contributor Author

Running into this issue it seems: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764335.

@cole-miller cole-miller force-pushed the musl-ci branch 4 times, most recently from b445c6d to 78dddc5 Compare August 11, 2024 20:32
REPO_SQLITE="https://github.com/sqlite/sqlite"
REPO_DQLITE="https://github.com/cole-miller/dqlite"

TAG_MUSL_COMPAT="main"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include a test run against the musl tag used in our k8s distributions: https://github.com/canonical/k8s-dqlite/blob/master/hack/env.sh#L13? We might not always be on the same musl version as the juju team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juju will be happy to move to the later one, now we know the root cause. We intended to move that originally but ended up locating the segfault.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@cole-miller cole-miller force-pushed the musl-ci branch 9 times, most recently from 92c73e8 to 5f862d2 Compare August 15, 2024 05:51
@cole-miller
Copy link
Contributor Author

I like how using a Dockerfile for this cleans things up. Looking into the segfaults.

musl doesn't have this header and it seems we don't use it.

Signed-off-by: Cole Miller <cole.miller@canonical.com>
This clashes with a #define in a system header.

Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants