Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch pause container to eks-d one #18

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Switch pause container to eks-d one #18

merged 2 commits into from
Feb 3, 2021

Conversation

ktsakalozos
Copy link
Member

Fixes #16

joedborg
joedborg approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@joedborg joedborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pahud
Copy link

pahud commented Jan 28, 2021

This is awesome! So we can deploy eks snap everywhere including China.

@pahud
Copy link

pahud commented Feb 3, 2021

Hi, any chance we can fix the CI error and hopefully merge this PR?

@ktsakalozos ktsakalozos merged commit c17a7cf into master Feb 3, 2021
@ktsakalozos
Copy link
Member Author

Hi, any chance we can fix the CI error and hopefully merge this PR?

Should be released soon. Thank you for keeping track of it.

@pahud
Copy link

pahud commented Feb 4, 2021

Hi, any chance we can fix the CI error and hopefully merge this PR?

Should be released soon. Thank you for keeping track of it.

Awesome! It works! https://github.com/pahud/cdk-eksdistro/issues/2#issuecomment-773301041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joedborg joedborg joedborg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to install in China
3 participants
@ktsakalozos @pahud @joedborg