Device release page #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
reviewed
Sep 20, 2022
lib/firmware_body_page.dart
Outdated
| State<FirmwareBodyPage> createState() => _FirmwareBodyPageState(); | ||
| } | ||
|
|
||
| class _FirmwareBodyPageState extends State<FirmwareBodyPage> { |
There was a problem hiding this comment.
FirmwareBodyPage could be a StatelessWidget?
There was a problem hiding this comment.
Ah, yes of course.. that was kind of the point 😆
test/device_model_test.dart
Outdated
| }); | ||
|
|
||
| test('verify', () async { | ||
| final device = testDevice(id: ''); |
There was a problem hiding this comment.
same here, could you set a non-empty id please :)
test/device_model_test.dart
Outdated
| }); | ||
|
|
||
| test('install release', () async { | ||
| final device = testDevice(id: ''); |
There was a problem hiding this comment.
would be nice to specify a non-empty ID so it wouldn't match any default-constructed device below
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the release dialog as a page in the new layout. Design updates will follow.
DeviceBodyPage- renders the right pane in the master detail layout for each deviceDeviceModel- view model forDeviceBodyPageinstall(),verify()for the device by calling the respective methods of theFirmwareModelDeviceBodyPagewill respond accordingly