Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup DevicePage and ReleasePage #73

Merged
merged 1 commit into from Sep 23, 2022
Merged

cleanup DevicePage and ReleasePage #73

merged 1 commit into from Sep 23, 2022

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Sep 23, 2022

access device properties and methods through provider instead of parameters and callbacks

@d-loose
cleanup DevicePage and ReleasePage
0b3b1b3 
access device properties and methods through provider instead of
parameters and callbacks
jpnurmi
jpnurmi approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@d-loose d-loose merged commit 3590643 into canonical:main Sep 23, 2022
@d-loose d-loose deleted the cleanup_device_release_page branch September 23, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-loose @jpnurmi