-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust filewriting #147
More robust filewriting #147
Conversation
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Beware that adding a new dependency means having to update the Launchpad Debian package recipe (and import that new dependency in the repository).
Thanks for the heads up, I'll have a look. |
@freeekanayaka So I think I have to update the recipe here https://code.launchpad.net/~dqlite/+recipe/dqlite, but I don't really find where I can add the repository to the list of Thanks a lot if you could give me a pointer in the right direction. |
You should be able to create a new import from GitHub using this link https://code.launchpad.net/+code-imports/+new |
tar isn't happy with the changes made in go-dqlite as part of canonical/go-dqlite#147.
There are some mentions of corrupted / empty
cluster.yaml
files. This PR should help prevent these cases.Fixes #145