github: Run go test in CI

[cole-miller]

We already run go test on Launchpad, but not for pull requests. Not sure whether there's a reason for that, so I'm opening this PR to facilitate discussion.

Signed-off-by: Cole Miller cole.miller@canonical.com

[tomponline]

Is there a reason you dont use go test go-dqlite/...?

[tomponline]

@markylaing I would appreciate your thoughts on this one given youve done a lot of our github ci stuff lately. Thanks

[cole-miller]

Is there a reason you dont use go test go-dqlite/...?

I'm not super familiar with the Go command-line syntax, so I just copied what Launchpad was doing. I'll simplify it, one sec...

[tomponline]

Is there a reason you dont use go test go-dqlite/...?

I'm not super familiar with the Go command-line syntax, so I just copied what Launchpad was doing. I'll simplify it, one sec...

Thanks you could take a look at what we do in the lxd github repo, as that way we won't need to remember to add each sub package to the list. Probably worth updating launchpad too otherwise things may be missed there also. Thanks

[tomponline]

Why vet off btw?

[cole-miller]

Why vet off btw?

That's also as in Launchpad -- I wanted to keep the two in sync, but I can remove `-vet=off` in both places if you approve (and if you can point me to where the definitions for the go-dqlite Launchpad build jobs live -- I haven't been able to find them).

…

On Wed, Sep 7, 2022 at 4:14 PM Tom Parrott ***@***.***> wrote: ***@***.**** commented on this pull request. Why vet off btw? — Reply to this email directly, view it on GitHub <#201 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMYX2CRRGWZ52KO3LSTPQUTV5DZUBANCNFSM6AAAAAAQHCIV4U> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[stgraber]

https://github.com/canonical/dqlite-ppa

[tomponline]

Does go test pass with vet off removed? If so I see no reason to leave it disabled. As for launchpad I'm not sure but agree they should be in sync. @stgraber can you point us to where the launchpad build scripts are? Thanks

[tomponline]

https://github.com/canonical/dqlite-ppa

Thanks!

[cole-miller]

Does go test pass with vet off removed?

Yes! Updated this PR. As for Launchpad, as far as I can tell, the arguments passed to go test aren't defined by us at all, they're managed by debian's packaging tools, which have their own idea of how to build and test Go projects.

[MathieuBordere]

overalls runs the tests, see here.

The following line in the .github actions file takes care of it.
overalls -project ${{ github.workspace }} -covermode=count -- -tags libsqlite3 -timeout 240s

$ overalls -help

usage: overalls -project=[path] -covermode[mode] OPTIONS -- TESTOPTIONS

overalls recursively traverses your projects directory structure
running 'go test -covermode=count -coverprofile=profile.coverprofile'
in each directory with go test files, concatenates them into one
coverprofile in your root directory named 'overalls.coverprofile'

[markylaing]

I had never heard of overalls before! Overall the test/lint actions in this repo look fine. We could use golangci-lint to add a few more linters like in LXD (see the static analysis target in the Makefile and the golangci-lint configuration file).

[cole-miller]

Thanks @MathieuBordere, looks like we do get test failure reports from overalls, so I'll revert this.