-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #42 - Downscaling Loki wipes its configuration #44
Conversation
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d like to see a cleanup of the excessive mocking in the tests. The rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Tests currently failing. Waiting to do a final review until it passes again. |
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Issue
See #42
Solution
Now we are no longer checking the event type, we are only checking if we have
loki_endpoints
provided by the Provider side of the relationContext
Testing Instructions
juju add-relation grafana-agent loki
juju scale-application loki 2
loki
section in grafana-agent config file is NOT empty:juju ssh --container agent agent/0 cat /etc/agent/agent.yaml
Release Notes