Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide authentication support for general Oauth *or* Anonymous access #139

Closed
mthaddon opened this issue Oct 11, 2022 · 6 comments
Closed

Comments

@mthaddon
Copy link
Contributor

Enhancement Proposal

In some cases we'd like to be able to enable anonymous read-only access to grafana in K8s, similar to how we currently can do with the machine version of the grafana charm.

Typically we'd put a proxy in front of this with SSO authentication tied to a particular team, but taking this approach means that we don't have to create specific users (and share/manage those credentials) for those who just want to browse existing graphs. That SSO proxy would happen outside of this charm, fwiw.

@rbarry82
Copy link
Contributor

There is an existing grafana_auth library, which is destructured enough that adding another method (such as anonymous auth) would be easy to add.

Note, however, that globally allowing anonymous auth in the charm was considered and rejected, whether or not the reactive charm does it (there are many things the reactive charm does which we do not intend to support without a "proper" design, rather than just putting them into the charm). We're happy to add support here, but would expect that, in a case where anonymous auth is needed, that an application which 'needs' it would need to provide those options via a relation.

@mthaddon
Copy link
Contributor Author

mthaddon commented Nov 9, 2022

Ok, so to clarify here a bit, we don't actually need anonymous access, but we do need some kind of authentication scheme that works for an organisation that doesn't involve manually creating/managing users and passwords. Possibly https://grafana.com/docs/grafana/latest/setup-grafana/configure-security/configure-authentication/google/ is the way to go here.

Possibly this issue isn't the best place to discuss this - let me know if it's better to close this out and discuss via other means.

@rbarry82
Copy link
Contributor

rbarry82 commented Nov 9, 2022

Actually, we were discussion adding generic OAuth to the grafana_auth library for the OSM team (to bridge to Keystone) for the same reason. The library is explicitly written to make extending it with the rest of the provider suite as easy as possible.

Are you sure Google is what you're looking for, or are there others also?

@mthaddon
Copy link
Contributor Author

I'm not tied to anything specific here if there's a better way of ensuring we can authenticate users. As I say, the main goal is to avoid needing to create user accounts/passwords manually.

@rbarry82
Copy link
Contributor

I guess let me rephrase -- OSM has a need for generic oauth, so we're definitely doing that, but we can implement other mechanisms also. AFAIK, there isn't a google-auth-integrator charm or anything, and providing "raw" configs to the library from the commandline wouldn't be that nice. We'd need that to tie into the ecosystem in a good way.

We're able to provide a better way of authenticating users, but do you have any more specific requirements than that?

@simskij simskij changed the title Provide option for allowing anonymous access Provide authentication support for general Oauth *or* Anonymous access Feb 27, 2023
@simskij
Copy link
Member

simskij commented Feb 27, 2023

I'll close this one with reference to #167 , to make it easier to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants