Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on controller storage #261

Open
sed-i opened this issue Sep 20, 2023 · 1 comment
Open

Do not rely on controller storage #261

sed-i opened this issue Sep 20, 2023 · 1 comment

Comments

@sed-i
Copy link
Contributor

sed-i commented Sep 20, 2023

Enhancement Proposal

We need to drop use_juju_for_storage=True because controller storage is deprecated.

main(GrafanaCharm, use_juju_for_storage=True)

Need to figure out how to go about dashboards and sources relations on upgrade-charm.

self._stored.set_default(dashboards={}) # type: ignore

self._stored.set_default( # type: ignore
sources={},
sources_to_delete=set(),
)

@lucabello
Copy link
Contributor

We need to find a solution for dashboard and sources; we should probably store those in a PVC, but how do we do that?

The only other alternative would be a peer relation, but (other than being a hacky solution) we would probably hit size limitations when storing all the dashboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants