Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some variable names in the grafana_source library #301

Open
lucabello opened this issue Feb 14, 2024 · 0 comments
Open

Refactor some variable names in the grafana_source library #301

lucabello opened this issue Feb 14, 2024 · 0 comments

Comments

@lucabello
Copy link
Contributor

Enhancement Proposal

The grafana_source library, and specifically GrafanaSourceProvider, provides some constructor arguments which should be refactored, namely:

  • extra_fields
  • secure_extra_fields

When they are translated in datasource configuration from Grafana, in _generate_datasource_config() they are converted in jsonData and secureJsonData respectively.

This requires change in the Provider, possibly in the Requirer as well (to read them from relation data?) and in the charm.

Thus, the name of the constructor arguments (and probably the variables) should be refacored to match the field names in the datasource configuration, meaning:

  • extra_fields => json_data
  • secure_extra_fields => secure_json_data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant