Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable resource limits #110

Merged
merged 9 commits into from
Aug 16, 2022
Merged

enable resource limits #110

merged 9 commits into from
Aug 16, 2022

Conversation

dstathis
Copy link
Contributor

@dstathis dstathis commented Aug 3, 2022 •
edited by sed-i

Issue

Add resource limits

Solution

Use the new library

Testing Instructions

Check limits work

Additional Context

canonical/observability-libs#19

Release Notes

Added resource limits to grafana-k8s as a config option

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch not found in Charmhub.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.20.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

sed-i
sed-i reviewed Aug 3, 2022
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.20.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.20.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

@dstathis dstathis marked this pull request as ready for review August 7, 2022 17:59
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit updated to version 0.10.
stderr

sed-i
sed-i approved these changes Aug 8, 2022
View reviewed changes
tests/integration/test_resource_limits.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.
stderr

@github-actions
Copy link

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.
stderr

@rbarry82
Use new action types (as a dict), don't immediately exit _configure b…
04d095d 
…efore pushing config files if the resource patch hasn't applied
@github-actions
Copy link

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.
stderr

@github-actions
Copy link

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout 
Library charms.grafana_k8s.v0.grafana_dashboard has local changes, cannot be updated.
Library charms.grafana_k8s.v0.grafana_source has local changes, cannot be updated.
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.
Library charms.observability_libs.v0.kubernetes_compute_resources_patch was already up to date in version 0.1.
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.21.
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.
stderr

@dstathis dstathis merged commit b45afde into main Aug 16, 2022
@dstathis dstathis deleted the resource_limits branch August 16, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

@simskij simskij simskij approved these changes

@sed-i sed-i sed-i approved these changes

@rbarry82 rbarry82 Awaiting requested review from rbarry82

@balbirthomas balbirthomas Awaiting requested review from balbirthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dstathis @Abuelodelanada @simskij @sed-i @rbarry82