Make topology dropdown injection configurable #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbarry82
requested review from
sed-i,
Abuelodelanada,
balbirthomas,
dstathis and
simskij
as code owners
Merged
Abuelodelanada
approved these changes
Sep 9, 2022
sed-i
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Instead of inserting topology dropdowns on every dashboard in every circumstance, add arguments to
GrafanaDashboardProviderto make this injection configurable. This is added as an additional per-dashboard key in the relation data, and used to determine whether or not to inject them.Closes #95
Solution
Read the key in
GrafanaDashboardProvider, and default toTrueto maintain compatibility with providers which may not set this (by default, it is opt-in).As part of this, since the datasource dropdown is still desirable, break
TEMPLATE_DROPDOWNSinto two separate objects and combine if appropriate given the option.Add unit tests.
Release Notes
Allow opt-out of topology dropdown injection