Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics endpoint generated using fqdn #222

Merged
merged 4 commits into from Jun 20, 2023
Merged

metrics endpoint generated using fqdn #222

merged 4 commits into from Jun 20, 2023

Conversation

Abuelodelanada
Copy link
Contributor

Issue

This PR fix #217

Solution

Now we use fqdn rather than IP

@Abuelodelanada Abuelodelanada requested a review from a team June 16, 2023 17:01
@Abuelodelanada Abuelodelanada merged commit 091e899 into main Jun 20, 2023
13 checks passed
@Abuelodelanada Abuelodelanada deleted the scrape_endpoint branch June 20, 2023 12:08
PietroPasotti
PietroPasotti reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Abuelodelanada Abuelodelanada mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti PietroPasotti left review comments

@lucabello lucabello lucabello approved these changes

@sed-i sed-i Awaiting requested review from sed-i sed-i is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrape endpoint doesn't update on reboot.
3 participants
@Abuelodelanada @PietroPasotti @lucabello