Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TLS #226

Merged
merged 21 commits into from
Jul 21, 2023
Merged

Implement TLS #226

merged 21 commits into from
Jul 21, 2023

Conversation

lucabello
Copy link
Contributor

Issue

Closes #225.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
tests/integration/test_tls_web.py Dismissed Show dismissed Hide dismissed
@lucabello lucabello marked this pull request as ready for review July 17, 2023 09:15
@lucabello
Copy link
Contributor Author

This PR still needs for grafana to trust the CA of its own certificate so it can communicate with the other bundle components.

@lucabello lucabello changed the title WIP: Implement TLS Implement TLS Jul 20, 2023
PietroPasotti
PietroPasotti approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits, doesn't need a second round from me

charmcraft.yaml Show resolved Hide resolved
metadata.yaml
@@ -57,6 +61,8 @@ provides:
peers:
grafana:
interface: grafana_peers
replicas:
interface: grafana_replicas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have two peer relations now, how about a note on what each one is used for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need two?

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@lucabello lucabello mentioned this pull request Jul 21, 2023
Open
@simskij simskij merged commit 5555a13 into main Jul 21, 2023
13 checks passed
@simskij simskij deleted the feature/tls branch July 21, 2023 10:20
@sed-i sed-i mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti PietroPasotti approved these changes

@sed-i sed-i Awaiting requested review from sed-i sed-i is a code owner

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada Abuelodelanada is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TLS and enable it when a cert is available
4 participants
@lucabello @simskij @PietroPasotti @sed-i