Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update charm libraries #110

Merged
merged 1 commit into from
Mar 30, 2024
Merged

chore: Update charm libraries #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/charms/tls_certificates_interface/v3/tls_certificates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def _on_certificate_revocation_request(self, event: CertificateRevocationRequest
generate_csr,
generate_private_key,
)
from ops.charm import CharmBase, RelationJoinedEvent
from ops.charm import CharmBase, RelationCreatedEvent
from ops.main import main
from ops.model import ActiveStatus, WaitingStatus
from typing import Union
Expand All @@ -151,7 +151,7 @@ def __init__(self, *args):
self.certificates = TLSCertificatesRequiresV3(self, "certificates")
self.framework.observe(self.on.install, self._on_install)
self.framework.observe(
self.on.certificates_relation_joined, self._on_certificates_relation_joined
self.on.certificates_relation_created, self._on_certificates_relation_created
)
self.framework.observe(
self.certificates.on.certificate_available, self._on_certificate_available
Expand Down Expand Up @@ -179,7 +179,7 @@ def _on_install(self, event) -> None:
{"private_key_password": "banana", "private_key": private_key.decode()}
)

def _on_certificates_relation_joined(self, event: RelationJoinedEvent) -> None:
def _on_certificates_relation_created(self, event: RelationCreatedEvent) -> None:
replicas_relation = self.model.get_relation("replicas")
if not replicas_relation:
self.unit.status = WaitingStatus("Waiting for peer relation to be created")
Expand Down Expand Up @@ -316,7 +316,7 @@ def _on_all_certificates_invalidated(self, event: AllCertificatesInvalidatedEven

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 9
LIBPATCH = 10

PYDEPS = ["cryptography", "jsonschema"]

Expand Down
Loading