Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Only runs integration tests if other tests pass #29

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: Only runs integration tests if other tests pass #29

merged 1 commit into from
Jan 19, 2024

Conversation

gruyaume
Copy link
Contributor

Description

As requested in this charm's Charmhub listing review (PR #27), we only run integration tests when the other tests have passed. This should reduce unnecessary runs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gruyaume gruyaume requested a review from a team as a code owner January 19, 2024 15:52
@gruyaume gruyaume mentioned this pull request Jan 19, 2024
Closed
7 tasks
@gruyaume gruyaume merged commit 18d091c into main Jan 19, 2024
8 checks passed
@gruyaume gruyaume deleted the dev-test-reqs branch January 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gruyaume @ghislainbourgeois