Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Uses pip-tools and dependabot to manage dependencies and versions #30

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

saltiyazan
Copy link
Contributor

@saltiyazan saltiyazan commented Jan 26, 2024

Description

  • Removes renovate and replaces it with dependabot to automate dependency version updates
  • Replaces requirements.txt files with requirements.in, requirements.txt is generated using pip-tools"
  • Bumps lxd version as 5.17/stable does not exist anymore

Files were generated using the following commands:

  • pip-compile requirements.in
  • pip-compile test-requirements.in -c requirements.txt

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

Removes renovate and replaces it with dependabot to automate dependecy version updates
Replaces requirements.txt file with requirements.in, requirements.txt is generated using pip-tools
@saltiyazan saltiyazan requested a review from a team as a code owner January 26, 2024 12:55
@saltiyazan saltiyazan changed the title Uses pip-tools and dependabot to manage dependencies and versions chore: Uses pip-tools and dependabot to manage dependencies and versions Jan 26, 2024
@@ -51,7 +51,7 @@ jobs:
- name: Setup LXD
uses: canonical/setup-lxd@main
with:
channel: 5.17/stable
channel: 5.19/stable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use 5.0/stable here, as it is the LTS release. 5.19 support will be dropped when 5.22 is released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default version used in setup-lxd is 5.0/stable. removed the channel parameter.

@saltiyazan saltiyazan merged commit fbd1617 into main Jan 31, 2024
8 checks passed
@saltiyazan saltiyazan deleted the TLSENG-94-adds-pip-compile-and-dependabot branch January 31, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants