Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Implements new version of the lego_client lib #83

Merged
merged 3 commits into from
Mar 8, 2024
Merged

chore: Implements new version of the lego_client lib #83

merged 3 commits into from
Mar 8, 2024

Conversation

saltiyazan
Copy link
Contributor

Description

  • Implements the _validate_plugin_config required by the lib
  • Removes on_config_changed
  • Fixes tests
  • Improves tox configs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@saltiyazan
Implements the _validate_plugin_config required by the lib
a1e359b 
Removes on_config_changed
Fixes tests
Improves tox configs
@saltiyazan saltiyazan requested a review from a team as a code owner March 7, 2024 08:27
@saltiyazan saltiyazan marked this pull request as draft March 7, 2024 08:28
@saltiyazan saltiyazan marked this pull request as ready for review March 7, 2024 12:59
@saltiyazan saltiyazan merged commit 0c6afae into main Mar 8, 2024
8 checks passed
@saltiyazan saltiyazan deleted the TLSENG-133-use-latest-lib branch March 8, 2024 04:48
@saltiyazan saltiyazan mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saltiyazan @gruyaume