Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add 'device' to the list of supported scopes #155

Closed
alesstimec opened this issue May 6, 2024 · 2 comments
Closed

Please add 'device' to the list of supported scopes #155

alesstimec opened this issue May 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@alesstimec
Copy link

Enhancement Proposal

For device flow, we need to add 'device' to the list of supported scopes here https://github.com/canonical/hydra-operator/blob/main/src/charm.py#L77

@shipperizer shipperizer added the bug Something isn't working label May 6, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-870.

This message was autogenerated

@nsklikas
Copy link
Contributor

nsklikas commented May 8, 2024

The scopes that are advertised on the openid-configuration endpoint do not have to be the only scopes that are supported from the provider (https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata):

scopes_supported
RECOMMENDED. JSON array containing a list of the OAuth 2.0 [RFC6749] scope values that this server supports. The server MUST support the openid scope value. Servers MAY choose not to advertise some supported scope values even when this parameter is used, although those defined in [OpenID.Core] SHOULD be listed, if supported.

AFAICT you can create a client with the device scope.

But why do you need the device scope? Is this for some application specific logic? I am asking because this is not needed to perform the device flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants