-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iam 160 create charmed operator #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linting errors and the github workflows.
you can add the publish action now - it should only run on push, so when this PR will be approved and merged |
Could you update |
…ctions from charm.py. Changed Usage section in README.md
…t in charm.py. Corrected documentation in CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…e added when the operator is approved for publishing.
…ied on_push.yaml to incorporate publishing. Modified on_schedule, renovate, and update_libs yaml files to be consistent with the other identity stack repositories.
…ctions from charm.py. Changed Usage section in README.md
…t in charm.py. Corrected documentation in CONTRIBUTING.md
d600201
to
315cbb3
Compare
I rectified most comments. I have not included the changes, where I left a comment detailing why. If this PR is approved, I'll delete the previous one.
Updates not done: