Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add horizontal scalability #37

Merged
merged 4 commits into from Jul 18, 2022
Merged

Add horizontal scalability #37

merged 4 commits into from Jul 18, 2022

Conversation

arturo-seijas
Copy link
Collaborator

No description provided.

@arturo-seijas arturo-seijas marked this pull request as ready for review July 15, 2022 09:20
@arturo-seijas arturo-seijas changed the title Horizontal scalability Add horizontal scalability Jul 15, 2022
mthaddon
mthaddon reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
mthaddon
mthaddon approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@arturo-seijas arturo-seijas merged commit cdc9abc into main Jul 18, 2022
@arturo-seijas arturo-seijas deleted the horizontal-scalability branch July 18, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthaddon mthaddon mthaddon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arturo-seijas @mthaddon