Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical Ltd is replaced with Canonical & Use Go Modules #4

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

bugraaydogar
Copy link
Contributor

  • Use go modules instead of govendor
  • Change paths to canonical instead of CanonicalLtd

@bugraaydogar bugraaydogar force-pushed the master branch 2 times, most recently from 28d1a8f to 9daacad Compare April 8, 2021 08:15
@codecov-io
Copy link

Codecov Report

Merging #4 (118d09e) into master (cc86588) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   86.31%   85.71%   -0.61%     
==========================================
  Files          22       22              
  Lines         972      826     -146     
==========================================
- Hits          839      708     -131     
+ Misses        102       88      -14     
+ Partials       31       30       -1     
Impacted Files Coverage Δ
config/config.go 74.60% <ø> (-1.87%) ⬇️
datastore/memory/memory.go 81.51% <ø> (+0.09%) ⬆️
service/controller/action.go 0.00% <ø> (ø)
service/controller/controller.go 68.18% <ø> (-3.06%) ⬇️
service/controller/device.go 100.00% <ø> (ø)
service/controller/group.go 100.00% <ø> (ø)
service/controller/snap.go 75.00% <ø> (-4.07%) ⬇️
service/devicetwin/action.go 92.30% <ø> (-1.03%) ⬇️
service/devicetwin/action_response.go 93.68% <ø> (-0.38%) ⬇️
service/devicetwin/device.go 100.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc86588...118d09e. Read the comment docs.

@alfonsosanchezbeato
Copy link
Member

Looks good, but why docs/IoTManagement.svg is changed?

@bugraaydogar
Copy link
Contributor Author

bugraaydogar commented Apr 8, 2021

Looks good, but why docs/IoTManagement.svg is changed?

There is a link inside svg which was redirecting to old repository when user clicks to the picture.

@alfonsosanchezbeato
Copy link
Member

Looks good, but why docs/IoTManagement.svg is changed?

There is a link inside svg which was redirecting to old repository when user clicks to the picture.

I see, nice catch!

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfonsosanchezbeato alfonsosanchezbeato merged commit 73fe611 into canonical:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants