add charm path release action #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use tag-prefix as input as it is the same as the directory names
ca-scribner
reviewed
Apr 6, 2022
ca-scribner
reviewed
Apr 6, 2022
.github/workflows/release.yaml
Outdated
Comment on lines
16
to
17
| description: "Tag Prefix" | ||
| required: true |
There was a problem hiding this comment.
This is effectively charm-subdir-name, as by convention we're mapping both release tag and charms/___ to the same variable. Can we rename it?
some options:
charm-subdir-name: This feels most correct (that's what we're actually using it for). Although we do reuse this variable both for setting thecharm-pathbelow and for prefixing the release tag, so there's some obfuscation in the namecharm-name: this feels cleaner to me, but relies on the convention that we name ourcharms/___by charm name.
ca-scribner
approved these changes
Apr 6, 2022
agathanatasha
force-pushed
the
KF-266/second-attempt-on-release-action
branch
from
40b6e95
to
7a995c8
Compare
DnPlas
pushed a commit
that referenced
this pull request
May 5, 2022
* add charm path release action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release action fails because it can't find
metadata.yamlfile in the directory.Provide charm-path to release action. Use tag-prefix as input as it is the same as the directory names. This way users have one less field to fill