Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace subprocess with python-libjuju calls #11

Closed
zxhdaze opened this issue Apr 25, 2024 · 2 comments
Closed

Replace subprocess with python-libjuju calls #11

zxhdaze opened this issue Apr 25, 2024 · 2 comments

Comments

@zxhdaze
Copy link
Contributor

zxhdaze commented Apr 25, 2024

There are few places in the code, which rely on running subprocess and using juju.

It needs to be replaced with appropriate python-libjuju calls.


Imported from Launchpad using lp2gh.

@zxhdaze
Copy link
Contributor Author

zxhdaze commented Apr 25, 2024

(by zzehring)
Currently, python-libjuju does not implement a couple of key functions we need for the tool: retrieving all controllers and creating controller backups.

Here are the GH Issues for implementing those features:

controllers: juju/python-libjuju#529
controller backup: juju/python-libjuju#529

Once those are implemented, we can remove the subprocess calls and add the lib calls.

@zxhdaze
Copy link
Contributor Author

zxhdaze commented Apr 25, 2024

(by jfguedez)
The upstream issues have been resolved. The current code in master uses the API for creating controller backups.

@zxhdaze zxhdaze closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant