Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upkeep #33

Merged
merged 5 commits into from Aug 2, 2023
Merged

Upkeep #33

merged 5 commits into from Aug 2, 2023

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Aug 2, 2023 •
edited

Issue

Charm in need of some upkeep.

Solution

  • Add catalogue entry
  • Update service patch
  • Parametrized TLS test

Context

Testing Instructions

Release Notes

Upkeep.

@sed-i sed-i marked this pull request as ready for review August 2, 2023 19:47
@sed-i
Copy link
Contributor Author

sed-i commented Aug 2, 2023

Itests pass locally; fail in CI because charmcraft 2.4.0 is not yet stable.

@sed-i sed-i merged commit 7403042 into main Aug 2, 2023
12 of 13 checks passed
@sed-i sed-i deleted the feature/upkeep2 branch August 2, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

@lucabello lucabello Awaiting requested review from lucabello lucabello is a code owner

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti PietroPasotti is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sed-i @Abuelodelanada