Make logdump action output path configurable #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
bschimke95/make-log-dump-output-configurable
branch
from
d18e904
to
f85d535
Compare
Currently, the logdump action output path is hard-coded. Running this action twice in the same CI causes these actions to overwrite each others logs. With this commit, the path can now be configured by setting the `$LOGDUMP_OUTPUT_DIR` env variable in a workflow. If it is not set the path will fall-back to `tmp_logs_$GITHUB_JOB` with $GITHUB_JOB being the unique id of the current running job. Closes canonical#95
bschimke95
force-pushed
the
bschimke95/make-log-dump-output-configurable
branch
from
f85d535
to
cb299a8
Compare
DnPlas
reviewed
Sep 21, 2023
DnPlas
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logdump action output path is hard-coded. Running this action twice in the same CI causes these actions to overwrite each others logs.
With this commit, the path can now be configured by setting the
$LOGDUMP_OUTPUT_DIRenv variable in a workflow. If it is not set the path will fall-back totmp_logs_$GITHUB_JOBwith $GITHUB_JOB being the unique id of the current running job.Closes #95