Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci, build: update CI, libraries, python dependencies, and format #83

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jul 24, 2023

This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).

This change also contains a fix for #84, an issue caused by a missing toolchain in the charm that allows building certain python packages. For more information, please refer to canonical/bundle-kubeflow#648.

Fixes #84
Part of canonical/bundle-kubeflow#648

This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).
Copy link
Contributor

@phoevos phoevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget the following:

diff --git a/charms/tensorboard-controller/requirements-lint.in b/charms/tensorboard-controller/requirements-lint.in
index c77cd87..07a4a51 100644
--- a/charms/tensorboard-controller/requirements-lint.in
+++ b/charms/tensorboard-controller/requirements-lint.in
@@ -1,9 +1,8 @@
+black
 codespell
-flake8<6
+flake8
 flake8-builtins
-# Pinned because `flake8-copyright==0.2.3` is incompatible with `flake8>=6`.  Can unpin this
-# when https://github.com/savoirfairelinux/flake8-copyright/pull/20 or a similar fix is released
 flake8-copyright
+isort
 pep8-naming
 pyproject-flake8
--r requirements-fmt.txt
diff --git a/requirements-integration.in b/requirements-integration.in
index a07d242..e1a657e 100644
--- a/requirements-integration.in
+++ b/requirements-integration.in
@@ -1,4 +1,6 @@
 # Pinning to <3.0 to ensure compatibility with the 2.9 controller version
 # Note: 3.0 is not being maintained anymore
 juju<3.0
+pytest
 pytest-operator
+pyyaml

@DnPlas DnPlas merged commit b71ba37 into main Jul 26, 2023
14 checks passed
@DnPlas DnPlas deleted the KF-3870-ci-healthchecks branch July 26, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensorboards-web-app fails to build during integration tests
2 participants