Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add method to assess Multus availability #26

Merged
merged 2 commits into from
Jan 3, 2024
Merged

chore: add method to assess Multus availability #26

merged 2 commits into from
Jan 3, 2024

Conversation

dariofaccin
Copy link
Contributor

Description

This PR adds a method to assess Multus availability. This method will be used by charm requiring the library to set their status properly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner January 3, 2024 08:27
gatici
gatici reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Asked for one more test case.

@dariofaccin dariofaccin force-pushed the TELCO-922-add-check-multus-availability branch from f193563 to e978f14 Compare January 3, 2024 12:01
@dariofaccin dariofaccin merged commit aa10a97 into main Jan 3, 2024
8 checks passed
@dariofaccin dariofaccin deleted the TELCO-922-add-check-multus-availability branch January 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

@Gmerold Gmerold Gmerold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dariofaccin @gatici @Gmerold