Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replacing static list of NetworkAnnotations with the function #28

Merged

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Jan 9, 2024

Description

This PR is a part of DPDK in UPF.
Context:
NetworkAnnotations needed to support DPDK in the UPF are different from the default ones. This means that the list of NetworkAnnotations will be dynamically generated by the UPF charm, depending on the mode it's running in. This PR implements possibility of passing an arbitrary function generating a list of NetworkAnnotations instead of a fixed list to KubernetesMultusCharmLib's constructor.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@Gmerold Gmerold requested a review from a team as a code owner January 9, 2024 09:53
@Gmerold Gmerold merged commit 2bef83b into main Jan 9, 2024
15 checks passed
@Gmerold Gmerold deleted the TELCO-464-replacing-static-network-annotations-with-function branch January 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants