Read temperature from hwmon devices #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perfect5th
requested changes
Jan 29, 2024
|
@Perfect5th, I fixed the broken test and made the change you requested. Thanks for the review! |
|
Thanks for fixing the test! Unfortunately it looks like we're lacking test coverage on a few lines. Do you mind improving that as well? |
On most systems hwmon provides access to the temperature information on more devices, including the CPU and GPU on most systems. These additional temperature sources yield a more accurate maximum temperature for the overall system. With this change, the following precedence is used for reading thermal zones (depending on availability): 1. "/sys/class/hwmon/*/temp*_input" 2. "/sys/class/thermal/*/temp" 3. "/proc/acpi/thermal_zone/*/temperature"
|
@Perfect5th, There should be 100% coverage now for the change. |
Perfect5th
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most systems
hwmonprovides access to the temperature information on more devices, including the CPU and GPU on most systems. These additional temperature sources yield a more accurate maximum temperature for the overall system.With this change, the following precedence is used for reading thermal zones (depending on availability):
/sys/class/hwmon/*/temp*_input/sys/class/thermal/*/temp/proc/acpi/thermal_zone/*/temperature