Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build snap): switch to the python build plugin #224

Merged

Conversation

st3v3nmw
Copy link
Collaborator

@st3v3nmw st3v3nmw commented Mar 4, 2024

This PR should switch us over to using the python build plugin when building the snap to stop depending and being affected by changes on the .deb build process.

Make sure to run snapcraft clean before doing a manual test

@st3v3nmw st3v3nmw force-pushed the build-snap-with-python-plugin branch from 6b9d41e to 5b10d67 Compare March 4, 2024 09:36
@st3v3nmw st3v3nmw force-pushed the build-snap-with-python-plugin branch from 5b10d67 to cfd9837 Compare March 4, 2024 15:17
@st3v3nmw st3v3nmw marked this pull request as ready for review March 4, 2024 15:32
Copy link
Contributor

@Perfect5th Perfect5th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to snapcraft.yaml LGTM. Just running some manual build/install tests.

@Perfect5th Perfect5th merged commit 826d63f into canonical:master Mar 4, 2024
5 checks passed
@st3v3nmw st3v3nmw deleted the build-snap-with-python-plugin branch March 5, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants