Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): display correct landscape config command on snap #227

Conversation

st3v3nmw
Copy link
Collaborator

@st3v3nmw st3v3nmw commented Mar 7, 2024

When setting up with the snap, it displays the wrong command in the summary:

The landscape-config parameters to repeat this registration on another machine are:


sudo landscape-config --account-name [...]

It should now point to landscape-client.config instead:

The landscape config parameters to repeat this registration on another machine are:


sudo landscape-client.config --account-name [...]

@st3v3nmw st3v3nmw changed the title fix(setup): Display correct landscape-config command on snap fix(setup): display correct landscape-config command on snap Mar 7, 2024
@st3v3nmw st3v3nmw force-pushed the display-correct-repeat-reg-command-in-snaps branch from 7530739 to cabd4bd Compare March 7, 2024 10:15
@st3v3nmw st3v3nmw changed the title fix(setup): display correct landscape-config command on snap fix(setup): display correct landscape config command on snap Mar 7, 2024
Copy link
Contributor

@Perfect5th Perfect5th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-critical comment.

@mock.patch("landscape.client.configuration.print_text")
@mock.patch("landscape.client.configuration.getpass.getpass")
@mock.patch("landscape.client.configuration.input")
@mock.patch("landscape.client.configuration.show_help")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle reminder that mock.patch.multiple exists.

@Perfect5th Perfect5th merged commit 2614270 into canonical:master Mar 7, 2024
5 checks passed
@st3v3nmw st3v3nmw deleted the display-correct-repeat-reg-command-in-snaps branch March 8, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants