allow changing the landscape snap config using snap set #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to change the
landscape-client.confconfig file using snap set.snap setdoesn't allow us to view the previous value of the config so we have to clean up the snap config to detect changes on the next run. Unsetting the values helps us avoid conflicts with configuration written throughlandscape-client.config.It also expands the range of options that can be set. For instance, it's now possible to configure the plugins when using a gadget snap.
Please note that the landscape-client service needs to be restarted after config changes.
Issue reported by @dilyn-corner