Added flag to skip sending a registration request and minor fixes #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wck0
requested changes
May 13, 2024
Comment on lines
+483
to
+485
| ).strip('/') | ||
| self.landscape_domain = re.sub(r'^https?://', '', | ||
| self.landscape_domain) |
There was a problem hiding this comment.
I notice you are using single quotes instead of double quotes like we have elsewhere in the code. Our linters don't catch this, but it would be good to be consistent.
| return open(config.config).read().strip() + "\n" | ||
| with open(config.config) as fh: | ||
| text = fh.read().strip() + "\n" | ||
| return text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in interactive mode, the user is prompted if a registration message needs to be sent. However in silent mode, no such option exists, and one is always sent. This MR adds a flag to skip the registration request. This has uses such as interacting with WSL and also the client charm.
In addition some minor fixes were made: